Fix if-guard generation around dummy fields

Cirras · Sep 12, 2024 · af5eb5d · af5eb5d
1 parent b839b9a
commit af5eb5d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Incorrect (de)serialization of data structures containing both `<dummy>` and `<field>` elements.'
+  (Only `ChestCloseServerPacket` was impacted.)
+
 ## [1.1.1] - 2024-08-22
 
 ### Changed

diff --git a/protocol_code_generator/generate/object_code_generator.py b/protocol_code_generator/generate/object_code_generator.py
@@ -287,7 +287,7 @@ def _generate_dummy(self, protocol_dummy):
             .build()
         )
 
-        needs_if_guards = not self._data.serialize and not self._data.deserialize
+        needs_if_guards = not self._data.serialize.empty or not self._data.deserialize.empty
 
         if needs_if_guards:
             self._data.serialize.begin_control_flow("if len(writer) == old_writer_length")