Feature: job parameter region for all the commands and jobs #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-montano-circleci
approved these changes
Oct 1, 2024
david-montano-circleci
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way region is passed to to all jobs and commands in the orb. This used to be done using the environment variable values.
The new parameter is set to used the AWS_DEFAULT_REGION env as a default when it is not set, this env was used for some other commands already.
The change should be a major version as some of the commands are just using the default region defined in the profile or the defaults environment variables, and this won't work now as the region is always explicitly set.
Also the way to pass the value is standardised to pass the value instead of the name of an environment variable. Anyway, an environment variable can be passed, but using the $ notation instead of just the name.