-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RTL issue in payload #733
Conversation
It must be ltr because in RTL language the payload will be affected and we have some problems
Thanks for you contribution! |
The line |
I think JSON preview is for searching, inspection, and visual validation, not for reading a text like news or messages. I prefer the layout after changes in this PR. But I'm not a native RTL user. Maybe we could make a poll to get feedback from our community? |
@mreram Thanks for the @Drjacky Thanks for your input here. @MiSikora Had the same idea yesterday, so tweeted a question about the change: https://twitter.com/vbuberen/status/1467238705081503749?t=nT30nBL-UkyWXwOKUSUD9A&s=09 |
@mreram Would you please try to set |
I assume in json format or other programming languages it's rare to use other languages as a keyword. |
@Drjacky with textAlignment="gravity" And textAlignment="viewStart" is same as before. |
Same here. Also not a native RTL so hard to make a call. I believe some RTL users are coding ltr (at least the one I know personally) so I'm assuming ltr is also fine for visualizing payloads like JSON/XML and others. +1 for merging this |
Ok, if everyone agree here let's merge the fix. @mreram Thanks again for your contribution and making Chucker a better tool for everyone 🚀 |
All TextView(s) must be LTR because in RTL language the payload will be affected and we have some problems
📷 Screenshots
📄 Context
When our app is RTL mode we have some problems with payload texts.
📝 Changes
I added force LTR text direction in payload items.