Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Android 15 - Toolbar is not accessible on api level 35 #1280

Closed
robertdroid opened this issue Sep 9, 2024 · 6 comments
Closed
Labels
help wanted Extra attention is needed

Comments

@robertdroid
Copy link
Contributor

robertdroid commented Sep 9, 2024

✍️ Describe the bug

When I open the chucker activity from the notification list is not possible to tap the options in the toolbar, like search, share or go back.

💣 Steps to reproduce

  1. Update the targetSdkVersion to 35
  2. Run the project
  3. make an request
  4. Open the request from the notification list.
  5. Try to search or share some request.

🔧 Expected behavior

Be able to tap the options in the toolbar

📷 Screenshots

image
image

📱 Tech info

  • Device: Emulator (Android Studio API level 35)
  • OS: Android 15
  • Chucker version: 3.5.2 and 4.0.0

📄 Additional context

I had the same problem in my app, and this documentation help me to fix it https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge

@cortinico cortinico changed the title Toolbar is not accessible on api level 35 (Android 15) Add Support for Android 15 - Toolbar is not accessible on api level 35 Sep 9, 2024
@cortinico
Copy link
Member

Yup we need to add support for Android 15, contribs are more than welcome 🙏

@cortinico cortinico added the help wanted Extra attention is needed label Sep 9, 2024
@robertdroid
Copy link
Contributor Author

robertdroid commented Sep 9, 2024

You are using com.google.android.material, so you only need to add fitsSystemWindows when you use Toolbar after upload the target version

<com.google.android.material.appbar.MaterialToolbar [...] android:fitsSystemWindows="true" />

@cortinico
Copy link
Member

You are using com.google.android.material, so you only need to add fitsSystemWindows when you use Toolbar after upload the target version

Please send a PR with the fix and we can merge it 👍

robertdroid pushed a commit to robertdroid/chucker that referenced this issue Sep 10, 2024
* Upgrade targetSdk to 35
* Fix issue ChuckerTeam#1280.
@markoeltiger
Copy link

@cortinico please close this issue as it is fixed

@AlexAsRoger
Copy link

When do you plan to release the version with the fix? In the changelog it is part of the Unreleased version 🤔

@cortinico
Copy link
Member

When do you plan to release the version with the fix? In the changelog it is part of the Unreleased version 🤔

I'll make one over the coming weeks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants