Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set the host container daemon socket location #366

Merged

Conversation

andreabedini
Copy link

Hi there,

thanks for the wonderful initiative. This patch add the ability to set a custom location for the container daemon socket to mount into the containers, replicating act's --container-daemon-socket.

I am not familiar with dotnet or the project architecture so I am not sure if I did this right :-)

Copy link
Owner

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, you successfully reassembled how I did this for other act compatible container flags

@ChristopherHX ChristopherHX enabled auto-merge (squash) July 11, 2024 13:08
@ChristopherHX ChristopherHX merged commit 282ee8f into ChristopherHX:main Jul 11, 2024
38 checks passed
@andreabedini
Copy link
Author

Thank you!

@andreabedini andreabedini deleted the container-daemon-socket branch July 15, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants