Add blockTimer and rename to blockShift #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcardon
reviewed
May 31, 2018
| @deprecated("0.2.0", "Use blockShift instead.") | ||
| final def block[A](fa: F[A])(implicit F: Async[F], ec: ExecutionContext): F[A] = | ||
| final private[linebacker] def block[A]( |
There was a problem hiding this comment.
why do you need this at all when RC2 isn't compatible with cats 0.10?
| _ <- Async.shift(eEC) | ||
| a <- Applicative[F].pure(aE).rethrow | ||
| endEC <- select(end) | ||
| a <- Async[F].bracket(Async.shift[F](iEC))(_ => fa)(_ => Async.shift(endEC)) |
There was a problem hiding this comment.
so this is like the third time I see this. I think this is pointing to the need of either some package object or object definition of something like:
private[linebacker] final def dualShift[F[_], A](initialEc: ExecutionContext, endEc: ExecutionContext, action: F[A])(implicit F: Async[F]) =
F.bracket(Async.shift[F](initialEc))(_ => fa)(_ => Async.shift[F](encEc))Then just calling dualShift(ec1, ec2, fa) in different modules and you save all the copypasta.
jmcardon
reviewed
May 31, 2018
| private[linebacker] def blockingPool: ExecutionContext = blockingContext | ||
|
|
||
| @deprecated("0.2.0", "Use blockShift instead.") | ||
| final private[linebacker] def block[A]( |
There was a problem hiding this comment.
just because I got trolled, what's the point in only deprecating and just just outright removing when you don't need bincompat for 0.2 yet?
ChristopherDavenport
force-pushed
the
blockTimer
branch
from
7878774
to
2a60131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates dependencies and add
blockTimerwhich blocks and returns to an implicit timer and renames toblockShiftto be used generally.