chore: PHP 7.2 GitHub workflows #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChristianRiesen this passes locally for me with PHP 7.4 Can you allow the GitHub workflows to run? CI is green here: |
phil-davis
commented
Mar 4, 2024
| @@ -307,7 +307,7 @@ private function getBinaryCounter($counter) | |||
| */ | |||
| private function getTimecounter() | |||
| { | |||
| return floor((time() + $this->totpOffset) / $this->period); | |||
| return \intval(floor((time() + $this->totpOffset) / $this->period)); | |||
There was a problem hiding this comment.
floor gives a float tpye that actually has an integer value. intval()turns into into an actualint` type, which is what the return type is supposed to be.
phil-davis
commented
Mar 4, 2024
| * @return number | ||
| * @return int |
There was a problem hiding this comment.
This always returns an int and never a float (phpstan noticed this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub workflows for CI.
Just support PHP 7.2 and later.
php-cs-fixer 3.51 (latest)
get phpunit to pass locally (I used PHP 7.4 and phpunit 9.6.17)
get phpstan to pass locally (I used PHP 7.4 and phpstan 1.10.59)
IMO the code here should still work with PHP 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3
Related issue #40