This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
feat(autodiscovery): uniqueid, forceupdate config and retain config messae #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChristianKuehnel this also solves a few issues for me and looks good to me .. can we merge and release? |
|
@ChristianKuehnel friendly ping, would be wonderful if we could bring this into a release. And thanks for the feedback @maxx I'm glad it works for you too. |
|
I'm not using this tool any more and I don't have time to maintain it. Do
you want to take over the ownership?
Best,
Christian
Christian Fürst ***@***.***> schrieb am Fr., 28. Mai 2021,
22:53:
… @ChristianKuehnel <https://github.com/ChristianKuehnel> friendly ping,
would be wonderful if we could bring this into a release.
If anything is missing, I'm glad to look deeper into it.
And thanks for the feedback @maxx <https://github.com/maxx> I'm glad it
works for you too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYJMCBUCHPUONHINT523L3TQAGEFANCNFSM4SLY7O3A>
.
|
|
Thanks @ChristianKuehnel truly understand this ocf, I'm not too proficient in python, but maybe I could help a little if it comes to releases and admin etc. Or anyone else here? Cheers |
|
Hello, what is the status of this pull request (and the project) ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only combination of the 3 settings i could get #45 to work🤔