Skip to content
This repository has been archived by the owner on Aug 29, 2024. It is now read-only.

Add device to Home Assistant auto-discovery #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeteBa
Copy link
Contributor

@PeteBa PeteBa commented Sep 21, 2019

This PR adds a unique_id to the discovery payload so that sensors are persisted in the Entity Registry. In addition, this adds Device information so that you can see all of the entities associated with each physical MiFlora device.

@ChristianKuehnel , I have assumed that the only devices recognised are Xiaomi (Line 304). Is that correct or does the gateway also detect other manufacturers ? Also, I see in the library that MiFloraPoller.name() does not retrieve from cache but makes an additional bluetooth connection. Would it be worth caching name in the same way that firmware_version is cached ?

@eribbey
Copy link

eribbey commented Apr 13, 2021

@PeteBa To respond to your question regarding other manufacturers: I'm pretty sure a lot of the other brands on Amazon at least (for example, OLLIVAN) use the exact same internals as the Xiaomi products. I was able to connect my OLLIVAN sensors without any difficulty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants