My take on Refactor2 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the following from parser.h, which should only be in util.h: char *esc_bytes(const unsigned char *bytes, int length, int limit);
Change Parser_parese signature to:
int Parser_parse(Parser *self, const unsigned char *input, size_t length, size_t *consumed);
Previously, number of bytes consumed were returned on success, and negative values were returned for errors. To handle length up to SIZE_MAX, I changed the function to return bytes consumed in *consumed. Error return codes are now positive. Success is returned as 0, as before.
Extraneous input (consumed < length) is detected in Parser_parse and returned as error EXTRANEOUS_INPUT.
Remove unnecessary declaration of 'struct _CompilationUnit;'
previously:
extern ChpegByteCode *Compiler_compile(const unsigned char *input, size_t length,
int *result_return, int verbose);
now:
extern int chpeg_compile(const unsigned char *input, size_t length,
ChpegByteCode **bytecode_return, int verbose);
For consistency in API, return values should be int success/error codes;
anything else needs to be returned by setting a pointer passed in.
Replace ByteCode members with const ByteCode * inside Parser
Remove:
const char *ChpegParser_def_name(ChpegParser *self, int index);
Use instead: (made extern)
extern const char *ChpegByteCode_def_name(const ChpegByteCode *self, int index);
Remove error: CHPEG_ERR_INVALID_LENGTH = 5, (size_t length always >= 0)
Parser_parse() changes:
- Use local variables to avoid following pointers in VM inner loop
- Move RUNAWAY checking to SANITY_CHECKS
Add default memory allocation wrappers that exit upon failure.
… default bytecode
…d size_t and fprintf
… issue a warning about nonsense expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.