Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, fix GitHub Action workflows #977

Merged
merged 9 commits into from
Dec 19, 2021

Conversation

mtriff
Copy link
Member

@mtriff mtriff commented Dec 16, 2021

Description

Updates dependencies, refactor to fix linting issues, and fixes GitHub Action workflows. Specifically:

Code

  1. Refactor interfaces.ts and default configurations into individual files (removes dependency cycles)
  2. Update all dependencies (excluding Fuse -- breaking change)
  3. Fixed linting errors

GitHub Actions

  1. Removes deprecated methods for setting environment variables
  2. Fix Firefox installation for browser tests
  3. Add Chrome to browser tests
  4. Switch from IE to Edge in browser tests (IE web driver no longer configured by default -- IE is being retired mid-next year)
  5. Update GitHub Actions to use Node versions supported by dependencies (12+)
  6. Disable committing built files from within GitHub actions. Not compatible with protected master branch and does not look like it can be done securely. See discussion here.
  7. Remove JavaScript linting. Cannot use the same configuration for TypeScript and JavaScript linting without getting errors due to TypeScript rules being unknown by the JS base linter. See here for more details.
  8. Use Chrome with Cypress. Fixes flakey dropdown test in Electron.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mtriff mtriff changed the title Update adding to path to new syntax for GitHub Action Update dependencies, fix GitHub Action workflows Dec 17, 2021
@mtriff mtriff added dependencies Pull requests that update a dependency file refactor Pull request that refactors existing functionality labels Dec 19, 2021
@mtriff mtriff merged commit 9e65639 into master Dec 19, 2021
@mtriff mtriff mentioned this pull request Dec 19, 2021
8 tasks
@mtriff mtriff deleted the fix-selenium-workflow branch December 21, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor Pull request that refactors existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant