-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #751/#773 #787
Resolve #751/#773 #787
Conversation
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
+ Coverage 68.1% 68.22% +0.12%
==========================================
Files 22 22
Lines 1317 1322 +5
==========================================
+ Hits 897 902 +5
Misses 420 420
Continue to review full report at Codecov.
|
Does this PR will born ? |
Issue still open and bug still existing? |
PLEASE PLEASE, we need this |
clearChoices still doesn't work.
|
#1166 implements different logic around how items/choices so it should resolve this |
Description
Adds new
clearItems
method that can be called when usingsetChoices
by passing thereplaceChoices
argument. Fixes #751 and #773.Screenshots (if appropriate)
Types of changes
Checklist