Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #751/#773 #787

Closed
wants to merge 8 commits into from
Closed

Resolve #751/#773 #787

wants to merge 8 commits into from

Conversation

jshjohnson
Copy link
Collaborator

@jshjohnson jshjohnson commented Nov 28, 2019

Description

Adds new clearItems method that can be called when using setChoices by passing the replaceChoices argument. Fixes #751 and #773.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #787 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage    68.1%   68.22%   +0.12%     
==========================================
  Files          22       22              
  Lines        1317     1322       +5     
==========================================
+ Hits          897      902       +5     
  Misses        420      420
Impacted Files Coverage Δ
src/scripts/constants.js 84.61% <ø> (ø) ⬆️
src/scripts/actions/items.js 100% <100%> (ø) ⬆️
src/scripts/reducers/items.js 100% <100%> (ø) ⬆️
src/scripts/choices.js 56.93% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b7b3f...c188212. Read the comment docs.

@jshjohnson jshjohnson changed the title Resolve #751 Resolve #751/#773 Nov 28, 2019
@jshjohnson jshjohnson added the bugfix Pull request that fixes an existing bug label Nov 28, 2019
@kl3sk
Copy link

kl3sk commented Jan 8, 2020

Does this PR will born ?

@ireznik
Copy link

ireznik commented Apr 12, 2021

Issue still open and bug still existing?

@lnfel
Copy link

lnfel commented May 6, 2021

PLEASE PLEASE, we need this

@galievruslan
Copy link

clearChoices still doesn't work.

<button name="button" type="button" class="btn btn-secondary" data-action="click->check#clean"><i class="bi bi-eraser"></i> </button>

function clean(event) {
  let el = event.target.closest('form').querySelector('.form-select')
  let finded_choice_select = new Choices(el)
  finded_choice_select.clearChoices()
}

@Xon
Copy link
Collaborator

Xon commented Aug 6, 2024

#1166 implements different logic around how items/choices so it should resolve this

@Xon Xon closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate selected values after multiple re-setting choices
6 participants