Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #774 #777

Merged
merged 5 commits into from
Nov 24, 2019
Merged

Resolve #774 #777

merged 5 commits into from
Nov 24, 2019

Conversation

jshjohnson
Copy link
Collaborator

Description

Resolves issue #774.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshjohnson jshjohnson added the bugfix Pull request that fixes an existing bug label Nov 24, 2019
@codecov
Copy link

codecov bot commented Nov 24, 2019

Codecov Report

Merging #777 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #777      +/-   ##
=========================================
+ Coverage   67.49%   68.1%   +0.61%     
=========================================
  Files          22      22              
  Lines        1323    1317       -6     
=========================================
+ Hits          893     897       +4     
+ Misses        430     420      -10
Impacted Files Coverage Δ
src/scripts/actions/items.js 100% <ø> (ø) ⬆️
src/scripts/choices.js 56.77% <100%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d116f95...eb05d00. Read the comment docs.

@jshjohnson jshjohnson merged commit 62e849d into master Nov 24, 2019
@jshjohnson jshjohnson deleted the resolve-774 branch November 24, 2019 17:32
@jshjohnson jshjohnson changed the title Resolve 774 Resolve #774 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant