ADA accessibility label fixes #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, seems like the failed test is in regards to cypress not starting on the travis server. |
|
If you merge in latest master, the CI build should be fixed 👍 |
|
@jshjohnson Thanks. I merged master and all tests are passing. @bronzehedwick |
|
Thanks 👍 |
jshjohnson
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Update incorrect 'label-for' in demo index.html file. * Use placeholder value for search input aria label. * Updated input template test. * Adding the compiled, uglified JS.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Choices creates an input field with a role="textbox" in order to filter the available options. This input field has no associated label.
This PR passes the placeholder value to the input and sets it as an "aria-label".
This PR also updates an accessibility issue on the demo page where a label had the wrong id in the "for" attribute.
Motivation and Context
This change is required for ADA compliance.
How Has This Been Tested?
The Wave chrome extension can be run against the demo page. Before this PR, you will see the red error label next to the input type with role="textbox".
I updated the expected HTML in templates.test.js so that test is passing.
I ran the suite of tests using
npm run testthis uncovers errors inselect-multiple.spec.jsin the master branch and in this branch.Screenshots (if appropriate):
Types of changes
Checklist: