Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NodeList #612

Closed
wants to merge 1 commit into from
Closed

Conversation

SilencerWeb
Copy link

Description

Adds support for NodeList

Motivation and Context

Fixes #559

How Has This Been Tested?

Unfortunately, I didn't write any tests because I couldn't figure out where to place a test for that, but I added initialization with NodeList in the public/index.html file on the 461's line.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@GoldenMaximo
Copy link

Opened the issue and fixed it yourself, very nice.

@tinovyatkin
Copy link
Contributor

@jshjohnson I think this should be closed in favour of #693 ?

@jshjohnson
Copy link
Collaborator

@jshjohnson I think this should be closed in favour of #693 ?

Agreed 👍 Thanks @SilencerWeb but I've decided to remove the ability to pass multiple elements to one Choices instance. See the reasoning here: #693

@jshjohnson jshjohnson closed this Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If I pass a NodeList as elements, I get an error "Passed element was of an invalid type"
4 participants