Fix first option if disabled (#473) #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @markjoeljimenez. Could you add some tests to cover this change please? |
added 3 commits
September 1, 2019 23:26
…into patch-1 Merge from master
|
Hey @jshjohnson, I haven't written tests before so please let me know if my tests are sufficient enough. |
jshjohnson
requested changes
Oct 2, 2019
| .click(); | ||
| }); | ||
|
|
||
| it('first choice is disabled', () => { |
There was a problem hiding this comment.
Suggested change
| it('first choice is disabled', () => { | |
| it('disables the first choice', () => { |
|
|
||
| let selectValue; | ||
|
|
||
| it('first non-disabled choice is selected', () => { |
There was a problem hiding this comment.
Suggested change
| it('first non-disabled choice is selected', () => { | |
| it('selects the first non-disabled choice', () => { |
| @@ -230,6 +236,29 @@ <h2>Select one inputs</h2> | |||
| removeItemButton: true, | |||
| }); | |||
|
|
|||
| new Choices('#choices-disabled-first-choice-by-options', { | |||
There was a problem hiding this comment.
Suggested change
| new Choices('#choices-disabled-first-choice-by-options', { | |
| new Choices('#choices-disabled-choice-via-options', { |
|
Hey - i've opened a new PR with your fix + some tweaks over latest master. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #473.
The first disabled choice passed in as an option is not actually disabled.
Reproduced example
https://jsfiddle.net/uf9bmpy6/
Fix
We can simply pass in the disabled choice instead of checking whether it's preselected or not.