Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix selectbox issue #1081 #1093

Closed
wants to merge 1 commit into from

Conversation

ousmorez
Copy link
Contributor

@ousmorez ousmorez commented Jan 9, 2023

resolve #1080

Description

It's going to solve following bug:
#1080

Screenshots (if appropriate)

Types of changes

Add this condition to the if statement to open a dropdown. This means only type characters less than 2 in length inside the select box.

event.key.length === 1

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ousmorez
Copy link
Contributor Author

ousmorez commented Jan 9, 2023

@mtriff This time I didn't even clone the project on my computer, I just edited the considered line on github! I don't know what the problem is and how to write a end-to-end test for it.

The failed review is related to puppeteer, I just know that I can fix this problem on my computer by installing puppeteer, not sure if it will work here.

Can you help me?

@Xon
Copy link
Collaborator

Xon commented Aug 22, 2024

Fixed as part of #1166

@Xon Xon closed this Aug 22, 2024
@neurotools
Copy link

It's possible to backport this fix to the 10.x branch?

Some projects, including Laravel Filament 3.x depend on this branch and due to breaking changes in 11.x branch will not update the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type wrongful character in the selection box
3 participants