Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-custom-properties not picked up if option is inside an optgroup #543

Closed
powerbuoy opened this issue Mar 11, 2019 · 6 comments
Closed
Labels

Comments

@powerbuoy
Copy link

I've been using <option data-custom-properties="somevalue"> on my multiple select to store some additional data I need. This has been working fine until today when I wrapped my <option>s in an <optgroup>. Suddenly all my customProperties are null. This looks like a bug to me?

@powerbuoy powerbuoy changed the title data-custom-properties not picked up if option is inside an optgroup data-custom-properties not picked up if option is inside an optgroup Mar 11, 2019
@jshjohnson
Copy link
Collaborator

Please may you provide a jsfiddle highlighting the issue

@powerbuoy
Copy link
Author

powerbuoy commented Mar 12, 2019

Here's a fiddle that highlights this, and my other two issues in one:

https://jsfiddle.net/n7yvrdzL/8/

@dmuriel
Copy link

dmuriel commented May 17, 2019

Hi, I'm also facing this issue, there's any more info about this?

@stale
Copy link

stale bot commented Aug 25, 2019

Thanks for contributing to this issue. As it has been 60 days since the last activity, this issue is being automatically closed. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again!

@stale stale bot added the stale label Aug 25, 2019
@stale stale bot closed this as completed Sep 4, 2019
@Zilus
Copy link

Zilus commented Feb 10, 2020

this issue persist on 9.0.1

Zilus pushed a commit to Zilus/Choices that referenced this issue Feb 10, 2020
@Black-Dragon-Spirit
Copy link

Dirty fix for this one is find the var addGroupChoices = function (choice) { ... change the customPropeties: choice.customProperties in to customProperties: choice.getAttribute('data-custom-properties'),

@Xon Xon mentioned this issue Aug 6, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants