Skip to content

Commit

Permalink
Fix documentation that suggests duplicateItemsAllowed works with sele…
Browse files Browse the repository at this point in the history
…ct-multiple, when it only works for text. #1123
  • Loading branch information
Xon committed Aug 10, 2024
1 parent cde52f0 commit 6e1426a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Fix Choices was not disable in a `<fieldset disabled>` [#1132](https://github.com/Choices-js/Choices/issues/1132)
* Fix `silent` option does not silence warnings about unknown options [#1119](https://github.com/Choices-js/Choices/issues/1119)
* Fix mutation APIs `setChoiceByValue`/`setChoices`/`setValue` now throw an error the Choices instance was not initialized or multiple choices instances where initialized on the same element. Prevents bad internal states from triggering unexpected errors [#1129](https://github.com/Choices-js/Choices/issues/1129)
* Fix documentation that suggests duplicateItemsAllowed works with select-multiple, when it only works for text. [#1123](https://github.com/Choices-js/Choices/issues/1123)

### Bug Fixes (from 11.0.0RC1)
* Fix possible empty `aria-label` generation on remove item button
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ Pass an array of objects:

**Type:** `Boolean` **Default:** `true`

**Input types affected:** `text`, `select-multiple`
**Input types affected:** `text`

**Usage:** Whether duplicate inputted/chosen items are allowed

Expand Down
2 changes: 1 addition & 1 deletion public/types/src/scripts/interfaces/options.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export interface Options {
/**
* Whether each inputted/chosen item should be unique.
*
* **Input types affected:** text, select-multiple
* **Input types affected:** text
*
* @default true
*/
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/interfaces/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export interface Options {
/**
* Whether each inputted/chosen item should be unique.
*
* **Input types affected:** text, select-multiple
* **Input types affected:** text
*
* @default true
*/
Expand Down

0 comments on commit 6e1426a

Please sign in to comment.