This commit was primary focused on stylefixes. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'num_files': num_files, | ||
| } | ||
| ) | ||
| elif self.max_num is not None and num_files > self.max_num: |
There was a problem hiding this comment.
I don't like the logic change here - it doesn't really change the logic but just makes it more complex to read.
|
Thanks for your PR! I've added some comments, wdyt? |
Stylefixes: 1. added `moduledocs` and class `doc-strings` 2. stylefixes 3. integrated `pylint` into the `tox`-testing process But there are a lot of other changes: 1. added new classificators to the `setup.py` 2. added `idea/` to `.gitignore` 3. added myself to `AUTHORS` 4. changed the way `LONG_DESCRIPTION` in `setup.py` was created (file was not closed) 5. forced `# -*- coding: utf-8 -*-` in all files 6. added `lint` to Travis builds 7. removed disscused issues
|
Awesome, thank you very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylefixes:
moduledocsand classdoc-stringspylintinto thetox-testing processBut there are a lot of other changes:
setup.pyidea/to.gitignoreAUTHORSLONG_DESCRIPTIONinsetup.pywas created (file was not closed)# -*- coding: utf-8 -*-in all files