Focus TextViewHighlighter on character changes #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSTextStorageDelegate
is informed about attribute changes, and the old setup would apply highlighting to attribute-only changes, too.That doesn't sound too bad unless you begin to store attribute in the text storage:
Neon/Sources/Neon/TextViewSystemInterface.swift
Lines 72 to 74 in 153d6e0
because then the highlighter loop will never stop.
Why I noticed and why I believe this is actually the correct way, stay tuned for Follow Up PR 3 :)