Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 enhance activity creation section and add functionality #79

Merged
merged 55 commits into from
Jul 2, 2024
Merged

feat: 🎸 enhance activity creation section and add functionality #79

merged 55 commits into from
Jul 2, 2024

Conversation

blp100
Copy link
Contributor

@blp100 blp100 commented Jun 27, 2024 •
edited
Loading

Description

  • add functionality with google map
  • add validation on necessary field
  • enhance image uploading functionality

Tasks

  • upload image
    • refactor upload image section
    • add image URLs in input text
  • add Google map function
  • fix functionality
    • date picker
    • activity type with google map or url
    • drop down menu with category
    • is recurring option
  • add tickets section functionality

Test

Screen.Recording.2024-06-30.at.12.49.36.AM.mov

Note

  • Changed Recurring design by setting default to hold activities weekly

TODO

  • enhance tickets section display
  • add welcome page into acitivity creation page
  • add preview

Others

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

Deploy preview for chillka-frontend ready!

✅ Preview
https://chillka-frontend-nwif2jp0g-north9hex.vercel.app

Built with commit 0470227.
This pull request is being automatically deployed with vercel-action

@blp100 blp100 force-pushed the feature/activity-creation-enhancements branch from 49e4179 to 57ef280 Compare June 27, 2024 08:50
@blp100 blp100 changed the title feat: 🎸 enhance activity creation section and add functionality feat: 🎸 enhance activity creaction section and add functionality Jun 27, 2024
@blp100 blp100 changed the title feat: 🎸 enhance activity creaction section and add functionality feat: 🎸 enhance activity creation section and add functionality Jun 28, 2024
@blp100 blp100 requested a review from zim314 June 29, 2024 16:30
@blp100 blp100 force-pushed the feature/activity-creation-enhancements branch from 26a3632 to 3289643 Compare June 30, 2024 03:56
@blp100 blp100 requested review from fufuShih and ellallu0903 June 30, 2024 09:02
@blp100 blp100 force-pushed the feature/activity-creation-enhancements branch from dbc4573 to 5bf168f Compare June 30, 2024 14:49
blp100 added 21 commits July 1, 2024 23:51
@blp100
refactor: tweak upload image function to use server action
be30616
@blp100
refactor: modify interface naming
cd2794a
@blp100
fix: set uploading state when all promises are done
ee5e98a
@blp100
feat: add organizer picture uploading functional
6f3662d
@blp100
fix: render issue on image preview
ad638c8
@blp100
refactor: optimize error handling
e2b932c
@blp100
feat: add image uploading functionality in activity content section
eb2dfe5
@blp100
feat: add map component wiht search functionality
dce5f58
@blp100
feat: update activity schema to match updated api
dd14ba8
@blp100
feat: add Google Maps functionality in form and retrieve values
32347f7
@blp100
fix: activity type didn't work issue
90fade4
@blp100
fix: remove unnessary input name on time picker
f1cd64a
@blp100
refactor: change directories naming
9b836b8
@blp100
feat: add category picker
79c8030
@blp100
refactor: remove comment
892285a
@blp100
feat: add date picker functionality with validation
6edba6a
@blp100
feat: enhance date validation
bf853f8
@blp100
feat: add placeholder on date and time picker
ece85e7
@blp100
feat: add fromToday & noEndDate functionality and validation
8f7f2ee
@blp100
fix: style issues
bf90cbb
@blp100
fix: value didn't change on date picker
02be65f
blp100 added 26 commits July 1, 2024 23:51
@blp100
feat: add online & offline choice and functionality
bf71700
@blp100
refactor: change state naming for better semantics
5e7c3e7
@blp100
feat: add activity link & location into zod schema
023ad8f
@blp100
feat: add recurring functionality
19373d9
@blp100
feat: optimize date picker user experience
0a5c515
@blp100
feat: display recurring day
df0ff70
@blp100
feat: add required field instructions
9bc5445
@blp100
fix: ensure location parameters are set correctly
8599215
@blp100
refactor: use same component for location and category
c78dc90
@blp100
feat: enhance form error validation
0f93ba9
@blp100
fix: correct naming typo
ac4004b
@blp100
fix: correct incorrect path in time picker component
1da5fc2
@blp100
feat: add tickets functionality with validation
a6e7d7d
@blp100
fix: date validation
d887b89
@blp100
feat: enhance tickets with asterisks for required fields
620730b
@blp100
fix: prevent form submission on pressing Enter in Google Maps search …
32687fa 
…field
@blp100
fix: add error message when image upload fails to respond
bd50568
@blp100
feat: disable form submission during image upload
20fa145
@blp100
feat: redirect after form validation and submission
e436e0c
@blp100
feat: add validation for empty tickets field
6fcb6c2
@blp100
feat: add side bar instruction
b8b3e33
@blp100
refactor: section ids
05a41a5
@blp100
fix: typo and add description
cc875a8
@blp100
feat: change runtime
3fa53f4
@blp100
fix: image size on cover section
c6e898b
@blp100
fix: incorrect error message on ticket end date
0470227
@blp100 blp100 force-pushed the feature/activity-creation-enhancements branch from 74d80ce to 0470227 Compare July 1, 2024 15:51
fufuShih
fufuShih approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@fufuShih fufuShih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前試沒什麼太大問題，如果之後有問題再開新PR去修這樣。

@blp100 blp100 merged commit 0187bc7 into main Jul 2, 2024
1 check passed
@blp100 blp100 deleted the feature/activity-creation-enhancements branch July 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufuShih fufuShih fufuShih approved these changes

@zim314 zim314 Awaiting requested review from zim314

@ellallu0903 ellallu0903 Awaiting requested review from ellallu0903

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blp100 @fufuShih