adjust the cost of secp256k1_verify upwards by 450k #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5276757095
💛 - Coveralls |
AmineKhaldi
approved these changes
Jun 15, 2023
richardkiss
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the secp256 operators are implemented using the unknown operators, the opcode determine its cost, and vice versa. In order to alter the cost, this patch also need to alter the opcode.
The new
secp256k1_verifyopcode is: 0x13d61f00The new cost of
secp256k1_verifyis: 1300000 (the cost is fixed, not related to what arguments are passed)