Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added py.typed to export hints for mypy, fixup hints #102

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Quexington
Copy link

No description provided.

@Quexington
Copy link
Author

This PR is technically good to go in terms of this repository, the problem is that since the types will be detectable now, the chia-blockchain repository is going to face a bunch of linting errors. Best hold off until there is a corresponding PR to fix those as well.

@altendky altendky changed the title Added py.typed files to packages so that mypy can analyze them Added py.typed to export hints for mypy, fixup hints Nov 24, 2021
@altendky
Copy link
Contributor

Unfixed errors are being ignored in Chia-Network/chia-blockchain#9371.

@mariano54
Copy link
Contributor

We should merge this imo @Quexington, dealing with the issues will be a good thing

@altendky
Copy link
Contributor

I had done some more hinting work, but I don't really recall the form and now it has become disconnected seemingly. #107 Maybe next week I could look back around this stuff? Maybe I'm being overly optimistic about that? :|

@Quexington
Copy link
Author

I agree @mariano54 it just would have required a rather large PR into chia-blockchain (and certainly a larger one now). One of the biggest fixes will be that SerializedProgram and Program will actually be distinct and there's a TON of places where we pass a Program where it's expecting the latter IIRC.

@Quexington Quexington marked this pull request as ready for review August 17, 2022 23:30
@altendky
Copy link
Contributor

I think we should at least have mypy running here? I'm taking a quick peek at catching up my other effort, now in #125. It might also be worth waiting until atari checkpoints to bulk edit main in blockchain in response to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants