-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added py.typed to export hints for mypy, fixup hints #102
base: main
Are you sure you want to change the base?
Conversation
This PR is technically good to go in terms of this repository, the problem is that since the types will be detectable now, the |
Unfixed errors are being ignored in Chia-Network/chia-blockchain#9371. |
We should merge this imo @Quexington, dealing with the issues will be a good thing |
I had done some more hinting work, but I don't really recall the form and now it has become disconnected seemingly. #107 Maybe next week I could look back around this stuff? Maybe I'm being overly optimistic about that? |
I agree @mariano54 it just would have required a rather large PR into chia-blockchain (and certainly a larger one now). One of the biggest fixes will be that |
I think we should at least have mypy running here? I'm taking a quick peek at catching up my other effort, now in #125. It might also be worth waiting until atari checkpoints to bulk edit main in blockchain in response to this. |
No description provided.