Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIP-0014: Chialisp ASSERT_BEFORE_* conditions #59

Merged
merged 9 commits into from
May 4, 2023
Merged

CHIP-0014: Chialisp ASSERT_BEFORE_* conditions #59

merged 9 commits into from
May 4, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Feb 22, 2023 •
edited
Loading

and the softfork at height 3830000 4000000

@danieljperry danieljperry changed the title add CHIP for assert_before_* conditions CHIP-0014: Chialisp ASSERT_BEFORE_* conditions Feb 23, 2023
@danieljperry
Copy link
Contributor

This CHIP will add a new set of Chialisp conditions to mirror the existing ASSERT_[SECONDS | HEIGHT]_[RELATIVE | ABSOLUTE] conditions. These new conditions will enable expiring Offers; the status quo is that users must cancel Offers manually.

This CHIP is now in Review (Fast Track); we would like to get it into a build soon. It uses the standard mechanism to add Chialisp conditions, which requires a soft fork.

Feel free to chat about the CHIP on Chia Dev Forums:
https://developers.chia.net/t/chip-0014-chialisp-assert-before-conditions

Please leave your reviews in this PR.

@danieljperry
Copy link
Contributor

Reminder that this CHIP is being fast-tracked. We would like to get these conditions into a build soon. We will attempt to hold a public call on this CHIP within the next week. Meanwhile, we would greatly appreciate it if you could let us know what you think of it.

@danieljperry
Copy link
Contributor

We will hold a Zoom call to discuss this CHIP on Monday, March 6 at 7 AM PST (4 PM CET). This call will be recorded and posted here. If you would like to join, DM me Keybase for an invitation.

@danieljperry
Copy link
Contributor

Here is the recording of the Zoom call explaining this CHIP:
https://youtu.be/_CHs87Ywklw

hoffmang9
hoffmang9 previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danieljperry
Copy link
Contributor

Developers: Please have a look at this CHIP and leave your review in this PR. If no further changes are required it will be moved to Last Call soon.

@danieljperry
Copy link
Contributor

This CHIP is now in Last Call. If no further changes are required in the next 14 days, it will be moved to Final, after which no further changes will be allowed.

hoffmang9
hoffmang9 approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danieljperry
Copy link
Contributor

This CHIP is now Final. No further changes are allowed, other than errata.

@danieljperry danieljperry merged commit 12bb13c into main May 4, 2023
@danieljperry danieljperry deleted the assert-before branch May 4, 2023 06:06
BrandtH22 pushed a commit to BrandtH22/chips that referenced this pull request May 23, 2023
@arvidn @danieljperry @BrandtH22
CHIP-0014: Chialisp ASSERT_BEFORE_* conditions (Chia-Network#59)
3f0451c 
* add CHIP for assert_before_* conditions, and the softfork at height 3830000

* Assign CHIP number

* Add ASSERT_MY_BIRTH_* conditions

* Add link for ASSERT_MY_BIRTH conditions

* Update with ephemeral spend logic

* Clarify ephemeral coin spends

* Remove section about negative values

* Move to Last Call

* Move CHIP-14 to final

---------

Co-authored-by: danieljperry <[email protected]>
danieljperry added a commit that referenced this pull request Jun 28, 2023
@BrandtH22 @danieljperry @arvidn
CHIP-0015: NFT Metadata Extension (#62)
ba78af1 
* init commit

* Remove CHIP# Pending assignment

* Assign CHIP number 15 and move into Draft

* Assignment of CHIP#

* misplaced character

* yyolk recommendations and notes

* CHIP-0014: Chialisp ASSERT_BEFORE_* conditions (#59)

* add CHIP for assert_before_* conditions, and the softfork at height 3830000

* Assign CHIP number

* Add ASSERT_MY_BIRTH_* conditions

* Add link for ASSERT_MY_BIRTH conditions

* Update with ephemeral spend logic

* Clarify ephemeral coin spends

* Remove section about negative values

* Move to Last Call

* Move CHIP-14 to final

---------

Co-authored-by: danieljperry <[email protected]>

* Readme (#63)

* Update CHIP-14 status and assign greimela as a CHIP Editor

* Move CHIP-14 to Final

* Add CHIP-15 to readme (#64)

* Update status to include CHIPs 16-19 (#69)

* Add CHIP number (errata) (#70)

* additional basic examples

added additional basic examples
updated chip to include examples links
TODO - upload advanced examples

* Review ready commit

 - Inclusion of advanced examples
 - cleanup of old examples
 - inclusion of parsing/linting tools (main md file)
 - Inclusion of examples in additional assets (main md file)

* Move CHIP-15 to Review

* Move CHIP-15 to Last Call

* Move CHIP-15 to Final

---------

Co-authored-by: danieljperry <[email protected]>
Co-authored-by: Arvid Norberg <[email protected]>
Co-authored-by: Dan Perry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @danieljperry @hoffmang9