Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update costs of unknown conditions, part of the hard fork #181

Merged
merged 2 commits into from
Jun 20, 2023
Merged

update costs of unknown conditions, part of the hard fork #181

merged 2 commits into from
Jun 20, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jun 20, 2023 •
edited
Loading

This extends the condition codes that have cost to all 2-byte conditions (except ones with leading zero).

The formula changes to use a lookup table based on the second byte.

@arvidn arvidn force-pushed the unknown-condition-costs branch 2 times, most recently from 366ac6c to 9aed943 Compare June 20, 2023 21:11
@arvidn arvidn marked this pull request as ready for review June 20, 2023 21:11
richardkiss
richardkiss reviewed Jun 20, 2023
View reviewed changes
src/gen/opcodes.rs Outdated Show resolved Hide resolved
@arvidn arvidn force-pushed the unknown-condition-costs branch from 9aed943 to 3680cea Compare June 20, 2023 21:26
@arvidn @richardkiss
Update src/gen/opcodes.rs
5fb95d8 
Co-authored-by: Richard Kiss <[email protected]>
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5327568419

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.832%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/gen/opcodes.rs 3 4 75.0%
Totals Coverage Status
Change from base Build 5279334500: 0.0%
Covered Lines: 6520
Relevant Lines: 7258
💛 - Coveralls

richardkiss
richardkiss approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@richardkiss richardkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could try doing a PR to calculate this at run-time, in a portable way.

@arvidn arvidn merged commit 3887056 into main Jun 20, 2023
@arvidn arvidn deleted the unknown-condition-costs branch June 20, 2023 23:35
@arvidn arvidn mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardkiss richardkiss richardkiss approved these changes

Assignees

@richardkiss richardkiss

@bramcohen bramcohen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @richardkiss @bramcohen