-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta 18 #542
Conversation
Bitfield backprop is causing Windows 10 and Catalina to run out of files when plotting a 128 bucket k27 with the GUI. STDERR:
Plotter output: Please take a look @arvidn |
my suspicion is that the regression is caused by there now being 2 SortManager objects alive at the same time. Whereas previously (I believe) we would just use one at a time and then "flatten" the tables in between sorting. Now we save some I/O by reading from one sort manager and writing directly into the next. On MacOS, the file handle limit per process is unusually low, 256. And two sort managers with 128 Buckets sounds like it would just about exceed that limit (given there are probably a few other random file handles open too). I'm surprised about windows having an issue too, historically windows has had a very high limit of file handles per process (in the order of 32k, iirc). However, when reading from a sort manager, we should only need one file handle open at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AOK
Merged by hand |
[1.0beta18] aka Beta 1.18 - 2020-12-03
Added
Changed
Fixed