Standardize the Wallet API for generate_signed_transaction
#19209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
geoffwalmsley
approved these changes
Feb 5, 2025
markelrod
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the longest time the standard
Wallethas had a slightly different API to the other wallets forgenerate_signed_transactionthat take a list of amounts and puzzle hashes. It creates a lot of if/else's and frustration when one is trying to write something that calls a genericWalletProtocoltype. This PR changes the API to match and consolidates some of these if/else's.