Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchup: into long_lived/datalayer_merkle_blob from main @ 37df97e873836e9bd10fe20da3bd1dabab48a53e #19199

Conversation

altendky
Copy link
Contributor

Source hash: 37df97e
Remaining commits: 0

altendky and others added 14 commits January 27, 2025 08:18
seeing 25% hang rate and top successful time of 22 minutes so let's fail a bit quicker on the hangs.

https://github.com/Chia-Network/chia-blockchain/actions/runs/12712771698/usage
Remove no longer needed get_block_path.
* Add singleton_records to action scopes

* Extract SingletonRecord to its own file

* Fix test_lifecycle

* Fix wallet action scope test mock
…equest_unfinished_block2 (#19141)

Fix a typo when picking the best unfinished block in test_request_unfinished_block2.
Remove no longer needed has_peers_with_peak.
* Swap out `Payment` for `CreateCoin`

* Fix mypy-exclusions

* tweak
Allow coin selection of 0 value coins
* pyproject.toml consistency

* fixup
* Add some extra safety into `create_message_spend`

* Fix a poorly named variable
* move augmented to caller

* use undelying height_to_hash to check main chain
…h_replaced_generator (#19139)

Fix a plot ID calculation typo in test_unfinished_block_with_replaced_generator.
…long_lived_datalayer_merkle_blob_from_main_37df97e873836e9bd10fe20da3bd1dabab48a53e
@altendky altendky requested a review from a team as a code owner January 28, 2025 15:27
@altendky altendky added checkpoint_merge Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jan 28, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/core/full_node/test_full_node.py 33.3% lines 1474-1475
chia/wallet/did_wallet/did_wallet_puzzles.py 75.0% lines 86, 88
Total Missing Coverage
158 lines 4 lines 97%

Copy link

Pull Request Test Coverage Report for Build 13013823750

Details

  • 154 of 159 (96.86%) changed or added relevant lines in 39 files are covered.
  • 30 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.464%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/_tests/wallet/rpc/config.py 0 1 0.0%
chia/_tests/core/full_node/test_full_node.py 1 3 33.33%
chia/wallet/did_wallet/did_wallet_puzzles.py 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
chia/daemon/server.py 1 83.46%
chia/plotters/plotters.py 1 90.94%
chia/wallet/puzzles/puzzle_utils.py 1 76.19%
chia/rpc/rpc_server.py 3 88.85%
chia/_tests/core/util/test_lockfile.py 3 88.89%
chia/server/node_discovery.py 4 80.59%
chia/plotters/madmax.py 6 44.58%
chia/full_node/full_node.py 11 86.03%
Totals Coverage Status
Change from base Build 13011818419: -0.02%
Covered Lines: 105421
Relevant Lines: 115073

💛 - Coveralls

@altendky altendky closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge coverage-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants