improve logging of rate limits #18907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
arvidn
force-pushed
the
rate-limit-logging
branch
from
4eea3d7 to
658475e
Compare
altendky
requested changes
Nov 20, 2024
arvidn
force-pushed
the
rate-limit-logging
branch
from
658475e to
2c61993
Compare
arvidn
force-pushed
the
rate-limit-logging
branch
from
2c61993 to
2f212cf
Compare
altendky
previously approved these changes
Nov 20, 2024
altendky
approved these changes
Nov 20, 2024
|
emlowe
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Our rate limits sometimes have hard-to-predict behaviors. Trouble shooting is made more difficult by only logging at debug level when an outgoing message is dropped.
Current Behavior:
Outgoing messages being dropped by the rate limit is only logged at debug level, even though this should be a rare event.
New Behavior:
Dropping outgoing messages is logged at info-level along with which limit was exceeded, causing the message to drop.
When disconnecting a peer for sending a message exceeding the incoming rate limit, we print which limit was exceeded.
Testing Notes:
I've tested this by syncing two nodes on my local network.