Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1676] Make ruff an optional dependency #18780

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Quexington
Copy link
Contributor

Accidentally added this as a required dependency in #18759

@Quexington Quexington marked this pull request as ready for review October 28, 2024 14:22
@Quexington Quexington requested a review from a team as a code owner October 28, 2024 14:22
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Oct 28, 2024
@Quexington Quexington changed the title Make ruff an optional dependency [CHIA-1676] Make ruff an optional dependency Oct 28, 2024
altendky
altendky previously approved these changes Oct 28, 2024
emlowe
emlowe previously approved these changes Oct 28, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 28, 2024
@Quexington Quexington dismissed stale reviews from emlowe and altendky via c11f4ac October 28, 2024 21:07
@Chia-Network Chia-Network deleted a comment from github-actions bot Oct 28, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 28, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Oct 28, 2024
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Oct 29, 2024
@pmaslana pmaslana merged commit bc901da into main Oct 29, 2024
359 checks passed
@pmaslana pmaslana deleted the quex.ruff_optional_dependency branch October 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants