Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockchainInterface cleanups #18522

Merged
merged 5 commits into from
Aug 27, 2024
Merged

BlockchainInterface cleanups #18522

merged 5 commits into from
Aug 27, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 24, 2024 •
edited
Loading

This PR is best reviewed one commit at a time.

Purpose:

Minor simplifications of protocols.

Current Behavior:

  • The BlockInfo protocol has implementations for its functions
  • find_fork_point_in_chain() and lookup_fork_chain() takes BlockchainInterface
  • WalletBlockchain implements BlockchainInterface

New Behavior:

  • The BlockInfo protocol has empty functions
  • find_fork_point_in_chain() and lookup_fork_chain() takes the smaller FullBlocksProtocol
  • WalletBlockchain implements BlockRecordsProtocol

Testing Notes:

arvidn added 2 commits August 24, 2024 17:54
@arvidn
use ... in BlockInfo protocol
bbd36e1
@arvidn
move prev_block_hash() from BlockchainInterface into BlockRecordsProt…
0c38d02 
…ocol to transition find_fork_point_in_chain() and lookup_fork_chain() to use the more narrow protocol to lookup the chain
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 24, 2024
@arvidn arvidn marked this pull request as ready for review August 24, 2024 23:55
@arvidn arvidn requested a review from a team as a code owner August 24, 2024 23:55
@arvidn arvidn requested review from altendky and almogdepaz August 25, 2024 23:13
@arvidn arvidn force-pushed the block-interface-cleanups branch from 16e6c3f to a09d42d Compare August 26, 2024 14:47
@arvidn arvidn force-pushed the block-interface-cleanups branch from a09d42d to 5e4cb59 Compare August 26, 2024 14:54
@arvidn arvidn requested a review from wjblanke August 26, 2024 16:24
wjblanke
wjblanke approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok but would be nice to fix the test

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Aug 26, 2024
@pmaslana pmaslana merged commit d5c36e3 into main Aug 27, 2024
375 checks passed
@pmaslana pmaslana deleted the block-interface-cleanups branch August 27, 2024 15:58
@altendky altendky mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@almogdepaz almogdepaz almogdepaz approved these changes

@altendky altendky Awaiting requested review from altendky

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @wjblanke @almogdepaz @pmaslana