-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some files closer to where they should live. #18465
Conversation
eeacd45
to
085e772
Compare
647caa1
to
5815577
Compare
This PR is best reviewed one change at a time. This PR moves two files (the first two changes), and pulls out the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. There are some questionable formatting changes though (and pre-commit is complaining)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've sent some suggestions that when (batch) applied, would make CI green.
f984e9a
to
c159bca
Compare
Pull Request Test Coverage Report for Build 11373736330Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
b311119
to
0392475
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
0392475
to
b49387d
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
FIXED: move two files and factor out
IPAddress
Purpose:
Remove a few import cycles.
Current Behavior:
New Behavior:
Testing Notes: