Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork infrastructure #15299

Merged
merged 2 commits into from
May 19, 2023
Merged

Fork infrastructure #15299

merged 2 commits into from
May 19, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 16, 2023

These commits are best reviewed one at a time.

These two commits:

  1. Removes the soft-fork logic for the 1.7-soft fork (which has activated on mainnet)
  2. Adds the constants for the next soft fork (soft_fork3) as well as the 2.0 hard fork and plot filter adjustment heights.

This patch does not implement any of the soft-forks or hard forks behavior, they will be separate PRs. But since multiple people coordinate on these constants, it makes sense to land them separately, first.

@arvidn arvidn requested a review from a team as a code owner May 16, 2023 14:53
@arvidn arvidn requested a review from fchirica May 16, 2023 14:53
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 16, 2023
fchirica
fchirica previously approved these changes May 16, 2023
@arvidn arvidn force-pushed the fork-infrastructure branch from 513a452 to 6ae28aa Compare May 17, 2023 19:45
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label May 18, 2023
@arvidn arvidn closed this May 18, 2023
@arvidn arvidn reopened this May 18, 2023
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5017824603

  • 21 of 21 (100.0%) changed or added relevant lines in 9 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.008%) to 85.002%

Files with Coverage Reduction New Missed Lines %
tests/core/mempool/test_mempool.py 1 95.93%
chia/timelord/timelord.py 2 73.02%
chia/rpc/rpc_server.py 3 87.46%
chia/full_node/full_node.py 6 85.36%
Totals Coverage Status
Change from base Build 5016993464: 0.008%
Covered Lines: 75757
Relevant Lines: 88925

💛 - Coveralls

@wallentx wallentx merged commit 621c75e into main May 19, 2023
@wallentx wallentx deleted the fork-infrastructure branch May 19, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants