-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chia_rs to 0.2.3. and ASSERT_MY_BIRTH_* #14720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Mar 2, 2023
arvidn
force-pushed
the
bump-chia-rs-0.2.3
branch
from
March 2, 2023 14:55
c08808b
to
539aeec
Compare
arvidn
commented
Mar 2, 2023
arvidn
commented
Mar 2, 2023
AmineKhaldi
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
trepca
reviewed
Mar 3, 2023
aqk
reviewed
Mar 3, 2023
aqk
reviewed
Mar 3, 2023
aqk
reviewed
Mar 3, 2023
aqk
approved these changes
Mar 3, 2023
emlowe
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch bumps the chia_rs dependency to 0.2.3, which includes a number fixes and new features. Most importantly, it fixes a bug in the edge case parsing of `ASSERT_BEFORE_* conditions.
(The full changelog can be found here)
Spend
type (as the result of parsing conditions) now include two optional integers,birth_height
andbirth_seconds
, in case those conditions were specified. This affects tests that create objects of this type.SpendBundleConditions
now include two new fields, the sum of all addition amounts and removal amounts for the spend bundle. This can be used to easily compute the fee. This affects tests that create objects of this type.ASSERT_MY_BIRTH_HEIGHT
andASSERT_MY_BIRTH_SECONDS
ASSERT_MY_BIRTH_SECONDS_FAILED
andASSERT_MY_BIRTH_HEIGHT_FAILED
mempool_check_time_lock()
This PR is best reviewed one commit at a time.