Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chia_rs to 0.2.3. and ASSERT_MY_BIRTH_* #14720

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Mar 2, 2023

this patch bumps the chia_rs dependency to 0.2.3, which includes a number fixes and new features. Most importantly, it fixes a bug in the edge case parsing of `ASSERT_BEFORE_* conditions.

(The full changelog can be found here)

  • The Spend type (as the result of parsing conditions) now include two optional integers, birth_height and birth_seconds, in case those conditions were specified. This affects tests that create objects of this type.
  • The SpendBundleConditions now include two new fields, the sum of all addition amounts and removal amounts for the spend bundle. This can be used to easily compute the fee. This affects tests that create objects of this type.
  • There are two new condition codes, ASSERT_MY_BIRTH_HEIGHT and ASSERT_MY_BIRTH_SECONDS
  • There are two new error codes, ASSERT_MY_BIRTH_SECONDS_FAILED and ASSERT_MY_BIRTH_HEIGHT_FAILED
  • There is new logic that implements the behavior of these new conditions. (it's fairly straight-forward, it just amends mempool_check_time_lock()

This PR is best reviewed one commit at a time.

@arvidn arvidn requested a review from a team as a code owner March 2, 2023 11:17
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Mar 2, 2023
@arvidn arvidn force-pushed the bump-chia-rs-0.2.3 branch from c08808b to 539aeec Compare March 2, 2023 14:55
@arvidn arvidn requested a review from aqk March 2, 2023 21:55
Copy link
Contributor

@AmineKhaldi AmineKhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Mar 3, 2023
@wallentx wallentx merged commit 9e8dae6 into main Mar 3, 2023
@wallentx wallentx deleted the bump-chia-rs-0.2.3 branch March 3, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants