Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate removing dependency to lodash #68

Closed
bd82 opened this issue Jun 11, 2015 · 3 comments
Closed

investigate removing dependency to lodash #68

bd82 opened this issue Jun 11, 2015 · 3 comments

Comments

@bd82
Copy link
Member

bd82 commented Jun 11, 2015

lodash is a great library. however, it seems it will be much easier to consume Chevrotain
if it had no dependencies (In browsers/bower).

The hotspots in the code are already written in an imperative style for performance reasons.
So need to find how much functionality from lodash is really needed and what is the cost to replace it.

@bd82
Copy link
Member Author

bd82 commented Jun 14, 2015

there are 30+ functions used from lodash in the 'production' code.
this may be a bit too much to replace manually.

perhaps another chevrotain build artifact with a minimal custom lodash build will solve the problem?

@bd82
Copy link
Member Author

bd82 commented Aug 23, 2015

Closing this issue for now.

may revisit it in the future.

@bd82 bd82 closed this as completed Aug 23, 2015
@bd82
Copy link
Member Author

bd82 commented Jan 2, 2016

Revisiting, no dependencies will also make it easier to use as parts of other libraries.
maybe just refactor +re-implement the logic needed from lodash in a very 'naive' manner.
as it the performance does not really matter in 'none hotspots'.

@bd82 bd82 reopened this Jan 2, 2016
bd82 pushed a commit that referenced this issue Jan 2, 2016
bd82 pushed a commit that referenced this issue Jan 2, 2016
bd82 pushed a commit that referenced this issue Jan 2, 2016
bd82 pushed a commit that referenced this issue Jan 3, 2016
bd82 pushed a commit that referenced this issue Jan 4, 2016
bd82 pushed a commit that referenced this issue Jan 5, 2016
bd82 pushed a commit that referenced this issue Jan 5, 2016
bd82 pushed a commit that referenced this issue Jan 5, 2016
bd82 pushed a commit that referenced this issue Jan 6, 2016
bd82 pushed a commit that referenced this issue Jan 6, 2016
bd82 pushed a commit that referenced this issue Jan 6, 2016
bd82 pushed a commit that referenced this issue Jan 6, 2016
bd82 pushed a commit that referenced this issue Jan 7, 2016
bd82 pushed a commit that referenced this issue Jan 7, 2016
bd82 pushed a commit that referenced this issue Jan 8, 2016
bd82 pushed a commit that referenced this issue Jan 8, 2016
bd82 pushed a commit that referenced this issue Jan 8, 2016
bd82 pushed a commit that referenced this issue Jan 9, 2016
bd82 pushed a commit that referenced this issue Jan 9, 2016
bd82 pushed a commit that referenced this issue Jan 9, 2016
bd82 pushed a commit that referenced this issue Jan 9, 2016
bd82 pushed a commit that referenced this issue Jan 9, 2016
bd82 pushed a commit that referenced this issue Jan 10, 2016
bd82 pushed a commit that referenced this issue Jan 10, 2016
bd82 pushed a commit that referenced this issue Jan 10, 2016
bd82 pushed a commit that referenced this issue Jan 11, 2016
bd82 pushed a commit that referenced this issue Jan 11, 2016
@bd82 bd82 closed this as completed in 66b2270 Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant