Fix: should not add emptyDir sizeLimit conf if it is nil (kubeflow#2305)

Signed-off-by: Yi Chen <[email protected]> (cherry picked from commit 763682d)
ChenYi015 · Dec 10, 2024 · ea016d0 · ea016d0
1 parent 833ba5c
commit ea016d0
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/internal/controller/sparkapplication/submission.go b/internal/controller/sparkapplication/submission.go
@@ -502,20 +502,22 @@ func driverVolumeMountsOption(app *v1beta2.SparkApplication) ([]string, error) {
 
 		switch volumeType {
 		case common.VolumeTypeEmptyDir:
-			args = append(
-				args,
-				"--conf",
-				fmt.Sprintf(
-					"%s=%s",
+			if volume.EmptyDir.SizeLimit != nil {
+				args = append(
+					args,
+					"--conf",
 					fmt.Sprintf(
-						common.SparkKubernetesDriverVolumesOptionsTemplate,
-						common.VolumeTypeEmptyDir,
-						volume.Name,
-						"sizeLimit",
+						"%s=%s",
+						fmt.Sprintf(
+							common.SparkKubernetesDriverVolumesOptionsTemplate,
+							common.VolumeTypeEmptyDir,
+							volume.Name,
+							"sizeLimit",
+						),
+						volume.EmptyDir.SizeLimit.String(),
 					),
-					volume.EmptyDir.SizeLimit.String(),
-				),
-			)
+				)
+			}
 		case common.VolumeTypeHostPath:
 			args = append(
 				args,