Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): add --max-resolver-depth flag #7043

Merged
merged 15 commits into from
May 13, 2024

Conversation

cx-ruiaraujo
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo commented May 3, 2024

Closes #

Proposed Changes

  • Removed the constant 'MaxResolvedFiles' with the value 50 and implemented a new flag called --max-resolver-depth to change his value dynamically. The implementation of the flag is based on the PR-6790.
  • Decreased the value 50 to 15.
  • Changed the resolver behaviour. Now, when using the key 'include_vars' in a YAML file, the resolver will look for the file inside the folder 'current_path/vars' and then in the 'current_path'. This is the default behaviour of Ansible (docs).

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the feature New feature label May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@github-actions github-actions bot added the ansible Ansible query label May 6, 2024
@cx-ruiaraujo cx-ruiaraujo marked this pull request as ready for review May 6, 2024 22:21
@cx-andrep cx-andrep merged commit cfbb06d into master May 13, 2024
25 checks passed
@cx-andrep cx-andrep deleted the ruiar/add-flag-max-resolver-depth branch May 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible query feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants