Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): docker compose Shared Volumes Between Containers #6714

Merged
merged 7 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"id": "8c978947-0ff6-485c-b0c2-0bfca6026466",
"queryName": "Shared Volumes Between Containers",
"severity": "INFO",
"category": "Insecure Configurations",
"descriptionText": "Volumes shared between containers can cause data corruption or can be used to share malicious files between containers.",
"descriptionUrl": "https://docs.docker.com/compose/compose-file/compose-file-v3/#volumes",
"platform": "DockerCompose",
"descriptionID": "574aa3ab"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package Cx

import data.generic.common as common_lib

CxPolicy[result] {
resource := input.document[i]
service_parameters := resource.services[name]
volumes := service_parameters.volumes
volume := volumes[v]
startswith(volume, "shared-volume:")

result := {
"documentId": sprintf("%s", [resource.id]),
"searchKey": sprintf("services.%s.volumes",[name]),
"issueType": "IncorrectValue",
"keyExpectedValue": "There shouldn't be volumes shared between containers",
"keyActualValue": sprintf("There is a volume shared (%s) between containers", [volume]),
"searchLine": common_lib.build_search_line(["services", name, "volumes", v], []),
}
}

CxPolicy[result] {
resource := input.document[i]
service_parameters := resource.services[name]
volumes := service_parameters.volumes
volume := volumes[v]

dup(resource, name, volume)

result := {
"documentId": sprintf("%s", [resource.id]),
"searchKey": sprintf("services.%s.volumes",[name]),
"issueType": "IncorrectValue",
"keyExpectedValue": "There shouldn't be volumes shared between containers",
"keyActualValue": sprintf("There is a volume shared (%s) between containers", [volume]),
"searchLine": common_lib.build_search_line(["services", name, "volumes", v], []),
}
}

dup(resource, resource_name, volume_name){
service_parameters := resource.services[name]
name != resource_name
volumes := service_parameters.volumes
vname := volumes[_]
vname == volume_name
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
version: "3"

services:
frontend:
build: frontend
ports:
- "8000:80"
volumes:
- ./logic:/app

backend:
build: backend
expose:
- 8080
volumes:
- ./bin:/app
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
version: "3"

services:
frontend:
build: frontend
ports:
- "8000:80"
volumes:
- ./logic:/app

backend:
build: backend
expose:
- 8080
volumes:
- ./logic:/app
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
version: "3"
services:
app:
build: app
ports:
- "0.0.0.0:80:80"
volumes:
- shared-volume:/app/uploads
depends_on:
- checker

checker:
build: checker
expose:
- 8080
volumes:
- shared-volume:/uploads

volumes:
shared-volume:
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
[
{
"queryName": "Shared Volumes Between Containers",
"severity": "INFO",
"line": 9,
"filename": "positive1.yaml"
},
{
"queryName": "Shared Volumes Between Containers",
"severity": "INFO",
"line": 16,
"filename": "positive1.yaml"
},
{
"queryName": "Shared Volumes Between Containers",
"severity": "INFO",
"line": 8,
"filename": "positive2.yaml"
},
{
"queryName": "Shared Volumes Between Containers",
"severity": "INFO",
"line": 17,
"filename": "positive2.yaml"
}
]
Loading