Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): added condition in convertExpression #6635

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix(parser): added condition in convertExpression #6635

merged 3 commits into from
Aug 24, 2023

Conversation

cx-henriqueAlvelos
Copy link
Contributor

Closes #6584

Proposed Changes

  • Changed condition
  • Test

I submit this contribution under the Apache-2.0 license.

@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Aug 11, 2023
@github-actions
Copy link
Contributor

kics-logo

KICS version: v1.7.4

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

@cx-henriqueAlvelos cx-henriqueAlvelos added the bug Something isn't working label Aug 11, 2023
@github-actions github-actions bot removed the bug Something isn't working label Aug 11, 2023
@liorj-orca
Copy link
Contributor

@cxMiguelSilva @gabriel-cx @pereiramarco011 @kaplanlior do you think we could push through this fix?

@gabriel-cx
Copy link
Contributor

Hi @liorj-orca ,
We will review and perform QA on this PR asap. We plan to have this fix in the KICS version 1.7.7.

pereiramarco011
pereiramarco011 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asofsilva asofsilva merged commit 954212d into master Aug 24, 2023
@asofsilva asofsilva deleted the kics-996 branch August 24, 2023 16:24
@chenrui333 chenrui333 mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereiramarco011 pereiramarco011 pereiramarco011 approved these changes

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json: error calling MarshalJSON for type model.Document: value is not known
5 participants
@cx-henriqueAlvelos @liorj-orca @gabriel-cx @pereiramarco011 @asofsilva