Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(regex) - Fix generic password regex rule #6461

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix(regex) - Fix generic password regex rule #6461

merged 2 commits into from
Jun 20, 2023

Conversation

pereiramarco011
Copy link
Contributor

Proposed Changes

  • Generic Password doesn't accept spaces

I submit this contribution under the Apache-2.0 license.

@github-actions
Copy link
Contributor

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

kaplanlior
kaplanlior approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@kaplanlior kaplanlior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabriel-cx gabriel-cx changed the title Bug(Engine) - Fix generic password regex rule fix(regex) - Fix generic password regex rule Jun 20, 2023
@pereiramarco011 pereiramarco011 merged commit f643dc1 into master Jun 20, 2023
@pereiramarco011 pereiramarco011 deleted the kics/regex-rule-fix branch June 20, 2023 15:13
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaplanlior kaplanlior kaplanlior approved these changes

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pereiramarco011 @kaplanlior @gabriel-cx