Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): ec2 instance monitoring disabled for CloudFormation #6401

Merged
merged 5 commits into from
May 26, 2023
Merged

feat(query): ec2 instance monitoring disabled for CloudFormation #6401

merged 5 commits into from
May 26, 2023

Conversation

cx-henriqueAlvelos
Copy link
Contributor

Proposed Changes

  • Added query for CloudFormation
  • Added metadata and tests for CloudFormation
  • Added positive_expected_results for CloudFormation

I submit this contribution under the Apache-2.0 license.

@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this May 19, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos added feature New feature query New query feature cloudformation CloudFormation query labels May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

pereiramarco011
pereiramarco011 previously approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@asofsilva asofsilva merged commit 2a6e2ea into master May 26, 2023
@asofsilva asofsilva deleted the bug/kics/779 branch May 26, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

@pereiramarco011 pereiramarco011 pereiramarco011 left review comments

@joaoReigota1 joaoReigota1 Awaiting requested review from joaoReigota1

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
cloudformation CloudFormation query feature New feature query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cx-henriqueAlvelos @gabriel-cx @pereiramarco011 @asofsilva