Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform/gcp): Add GKE Shielded Nodes is Disabled query for Terraform. #6248

Merged
merged 4 commits into from
May 29, 2023
Merged

feat(terraform/gcp): Add GKE Shielded Nodes is Disabled query for Terraform. #6248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
750f914
Add GKE Shielded Nodes is Disabled query for Terraform.
Mar 23, 2023
f9fec80
Fix up tests.
Mar 23, 2023
8a27182
Remove query for default positive.
Apr 17, 2023
9ac56ee
Bug fix and cleanup.
Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions assets/queries/terraform/gcp/shielded_gke_nodes_disabled/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"id": "579a0727-9c29-4d58-8195-fc5802a8bdb4",
"queryName": "Shielded GKE Nodes Disabled",
"severity": "MEDIUM",
"category": "Insecure Configurations",
"descriptionText": "GKE cluster nodes must be launched with Shielded VM enabled, which means the attribute 'enable_shielded_nodes' must be set to 'true'.",
"descriptionUrl": "https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#enable_shielded_nodes",
"descriptionID": "579a0727",
"platform": "Terraform",
"cloudProvider": "gcp"
}
18 changes: 18 additions & 0 deletions assets/queries/terraform/gcp/shielded_gke_nodes_disabled/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package Cx

import data.generic.terraform as tf_lib

CxPolicy[result] {
google_container_cluster := input.document[i].resource.google_container_cluster[name]
google_container_cluster.enable_shielded_nodes == false

result := {
"documentId": input.document[i].id,
"resourceType": "google_container_cluster",
"resourceName": tf_lib.get_resource_name(google_container_cluster, name),
"searchKey": sprintf("google_container_cluster[%s].enable_shielded_nodes", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": "google_container_cluster.enable_shielded_nodes should be set to true",
"keyActualValue": "google_container_cluster.enable_shielded_nodes is set to false",
}
}
5 changes: 5 additions & 0 deletions assets/queries/terraform/gcp/shielded_gke_nodes_disabled/test/negative.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
resource "google_container_cluster" "negative1" {
name = "my-gke-cluster"
location = "us-central1"
enable_shielded_nodes = true
}
5 changes: 5 additions & 0 deletions assets/queries/terraform/gcp/shielded_gke_nodes_disabled/test/positive.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
resource "google_container_cluster" "false" {
name = "my-gke-cluster"
location = "us-central1"
enable_shielded_nodes = false
}
8 changes: 8 additions & 0 deletions assets/queries/terraform/gcp/shielded_gke_nodes_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[
{
"queryName": "Shielded GKE Nodes Disabled",
"severity": "MEDIUM",
"line": 4,
"fileName": "positive.tf"
}
]