Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): update "Using Unrecommended Namespace" #4254

Merged
merged 4 commits into from
Sep 24, 2021
Merged

feat(query): update "Using Unrecommended Namespace" #4254

merged 4 commits into from
Sep 24, 2021

Conversation

rafaela-soares
Copy link
Contributor

@rafaela-soares rafaela-soares commented Sep 22, 2021 •
edited
Loading

Proposed Changes

  • Updated query to also check 'kube-public' and 'kube-system'
  • Renaming query from "Using Default Namespace" to "Using Unrecommended Namespace"
    I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added query New query feature kubernetes Kubernetes query labels Sep 22, 2021
@rafaela-soares rafaela-soares added this to the Queries Support milestone Sep 22, 2021
@rafaela-soares rafaela-soares self-assigned this Sep 22, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Sep 22, 2021

Scan submitted to Checkmarx

@rafaela-soares rafaela-soares marked this pull request as draft September 22, 2021 16:35
@kicsbot
Copy link
Contributor

kicsbot commented Sep 22, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

JoaoDuarteGomes
JoaoDuarteGomes previously approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@JoaoDuarteGomes JoaoDuarteGomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rafaela-soares rafaela-soares marked this pull request as ready for review September 23, 2021 18:55
rogeriopeixotocx
rogeriopeixotocx approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 6ed0be1 into master Sep 24, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/updating_using_default_namespace branch September 24, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@JoaoDuarteGomes JoaoDuarteGomes JoaoDuarteGomes left review comments

@joaoReigota1 joaoReigota1 Awaiting requested review from joaoReigota1

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@rafaela-soares rafaela-soares

Labels
kubernetes Kubernetes query query New query feature
Projects
None yet
Milestone
Queries Support
Development

Successfully merging this pull request may close these issues.
4 participants
@rafaela-soares @kicsbot @rogeriopeixotocx @JoaoDuarteGomes