Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable crash report variable name #3883

Merged
merged 5 commits into from
Jul 20, 2021
Merged

fix: disable crash report variable name #3883

merged 5 commits into from
Jul 20, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

Closes #3876

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added documentation Improvements or additions to documentation go Pull requests that update Go code labels Jul 17, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone Jul 17, 2021
@rogeriopeixotocx rogeriopeixotocx requested review from nunoocx, oribendetcx and a team July 17, 2021 10:43
@rogeriopeixotocx rogeriopeixotocx self-assigned this Jul 17, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jul 17, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jul 17, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx force-pushed the fix/disable-crash-report branch from f827cc7 to 4bee853 Compare July 17, 2021 10:48
felipe-avelar
felipe-avelar approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 0d108d7 into master Jul 20, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/disable-crash-report branch July 20, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-avelar felipe-avelar felipe-avelar approved these changes

@nunoocx nunoocx Awaiting requested review from nunoocx

@oribendetcx oribendetcx Awaiting requested review from oribendetcx

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
documentation Improvements or additions to documentation go Pull requests that update Go code
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

KICS_COLLECT_TELEMETRY environment variable not explained
4 participants
@rogeriopeixotocx @kicsbot @felipe-avelar @joaoReigota1