Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector): Fixed bug with detector getting the wrong line #2010 #3471

Merged
merged 1 commit into from
May 28, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #2010

Proposed Changes

  • Fixed detector, contains str2 will now look ahead from str1 IDX

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added the bug Something isn't working label May 28, 2021
@joaoReigota1 joaoReigota1 requested a review from a team May 28, 2021 10:33
@joaoReigota1 joaoReigota1 self-assigned this May 28, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 28, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 28, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 8b3d37f into master May 28, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/detect_line_bug branch May 28, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchKey on Terraform queries point to same line with multiple resources of the same type
4 participants