Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add "Template Path With No Corresponding Path Parameter" for OpenAPI #3366

Merged
merged 3 commits into from
May 21, 2021
Merged

feat(query): add "Template Path With No Corresponding Path Parameter" for OpenAPI #3366

merged 3 commits into from
May 21, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx commented May 18, 2021 •
edited
Loading

Proposed Changes

  • Checks if a template path has a corresponding path parameter for a given path
  • Checks if a template path has no path parameters defined for a given path

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added query New query feature openapi OpenAPI query labels May 18, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Queries Support milestone May 18, 2021
@rogeriopeixotocx rogeriopeixotocx requested a review from a team May 18, 2021 16:35
@rogeriopeixotocx rogeriopeixotocx self-assigned this May 18, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 18, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 18, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx force-pushed the feature/path_parameter_not_in_template branch from 2b5115b to 2375383 Compare May 18, 2021 16:41
@rogeriopeixotocx rogeriopeixotocx force-pushed the feature/path_parameter_not_in_template branch from 2375383 to 77fbd0c Compare May 18, 2021 17:18
@rogeriopeixotocx rogeriopeixotocx marked this pull request as draft May 19, 2021 14:32
@rogeriopeixotocx
Copy link
Contributor Author

Converting this query to a draft until we fix the detect line

@rogeriopeixotocx rogeriopeixotocx mentioned this pull request May 20, 2021
Closed
@joaoReigota1 joaoReigota1 marked this pull request as ready for review May 20, 2021 14:30
felipe-avelar
felipe-avelar approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit bc104f3 into master May 21, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/path_parameter_not_in_template branch May 21, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-avelar felipe-avelar felipe-avelar approved these changes

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
openapi OpenAPI query query New query feature
Projects
None yet
Milestone
Queries Support
Development

Successfully merging this pull request may close these issues.
4 participants
@rogeriopeixotocx @kicsbot @felipe-avelar @joaoReigota1