-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(report): corrected report directory generation #3201
fix(report): corrected report directory generation #3201
Conversation
Signed-off-by: Felipe Avelar <[email protected]>
Scan submitted to Checkmarx |
Signed-off-by: Felipe Avelar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a little touch
internal/console/scan.go
Outdated
formats = []string{filepath.Ext(outputPath)[1:]} | ||
err := consoleHelpers.ValidateReportFormats([]string{filepath.Ext(outputPath)[1:]}) | ||
if err != nil { | ||
log.Trace().Msgf("Not supported extension %s, will create directory instead", filepath.Ext(outputPath)[1:]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Trace().Msgf("Not supported extension %s, will create directory instead", filepath.Ext(outputPath)[1:]) | |
log.Trace().Msgf("Extension not supported %s, will create directory instead", filepath.Ext(outputPath)[1:]) |
Signed-off-by: Felipe Avelar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Felipe Avelar [email protected]
Closes #3158
Proposed Changes
I submit this contribution under the Apache-2.0 license.