Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sast): unhandled errors flagged by cxSAST #3095

Merged
merged 3 commits into from
May 4, 2021
Merged

fix(sast): unhandled errors flagged by cxSAST #3095

merged 3 commits into from
May 4, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

Proposed Changes

  • fixing unhandled error objects in swagger_utils.go and certificate_utils.go

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added bug Something isn't working security Security issues go Pull requests that update Go code labels May 4, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone May 4, 2021
@rogeriopeixotocx rogeriopeixotocx self-assigned this May 4, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 4, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 4, 2021 •
edited
Loading

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 2 vulnerabilities
High 0 High
Medium 0 Medium
Low 2 Low
Info 0 Info

Violation Summary

No policy violation found

@kicsbot
Copy link
Contributor

kicsbot commented May 4, 2021

Scan not submitted to Checkmarx due to existing Active scan for the same project.

@rogeriopeixotocx
Update swagger_utils.go
581739f 
Signed-off-by: Rogério Peixoto <[email protected]>
@rogeriopeixotocx rogeriopeixotocx force-pushed the fix/sast-unhandled-errors-low-results branch from 85399e3 to 581739f Compare May 4, 2021 14:07
joaoReigota1
joaoReigota1 approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit c8ea1ca into master May 4, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/sast-unhandled-errors-low-results branch May 4, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoReigota1 joaoReigota1 joaoReigota1 approved these changes

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
bug Something isn't working go Pull requests that update Go code security Security issues
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.
3 participants
@rogeriopeixotocx @kicsbot @joaoReigota1