Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): multiple paths on --path flag #3017

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

felipe-avelar
Copy link
Contributor

Closes #3001

Proposed Changes

  • KICS now accepts multiple paths on -p flag
  • Some docs update

Considerations

  • If -p has more than one value, kics.config will not be loaded automatically, configuration flag must be explicit used to load any configuration file.

I submit this contribution under Apache-2.0 license.

@felipe-avelar felipe-avelar added feature New feature community Community contribution labels Apr 27, 2021
@felipe-avelar felipe-avelar added this to the CLI/UI milestone Apr 27, 2021
@felipe-avelar felipe-avelar self-assigned this Apr 27, 2021
@felipe-avelar felipe-avelar changed the title Multiple paths on --path flag feat(engine): multiple paths on --path flag Apr 27, 2021
@rogeriopeixotocx rogeriopeixotocx added go Pull requests that update Go code and removed community Community contribution labels Apr 27, 2021
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, can we have just 1 E2E test before merging?

joaoReigota1
joaoReigota1 previously approved these changes Apr 27, 2021
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Felipe Avelar <[email protected]>
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 2d3770f into master Apr 27, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/multiple-input-paths branch April 27, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change flag --path to accept multiple paths
3 participants